Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes template literal in develop command #5630

Merged

Conversation

andrewhickey
Copy link
Contributor

When running develop the catchall (*) route will not find any pages. This should resolve that problem.

Signed-off-by: Andrew Hickey <andrewhickey@live.co.uk>
@andrewhickey
Copy link
Contributor Author

Looks like there was a typo in #4756.
This means that opening localhost:8000 when following the tutorial results in an empty response.

@KyleAMathews
Copy link
Contributor

Deploy preview for using-glamor failed.

Built with commit d246dbb

https://app.netlify.com/sites/using-glamor/deploys/5b1003b28df8943fd5f98714

Copy link
Contributor

@m-allanson m-allanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh-oh, thanks for the fix!

@andrewhickey
Copy link
Contributor Author

Got some failing builds, anything I can do about that?

@m-allanson
Copy link
Contributor

I don't think they're related to your changes. There was a hiccup with a recent publish, I've restarted the Travis tests.

@jlengstorf
Copy link
Contributor

Hiya @andrewhickey! 👋

This is definitely late, but on behalf of the entire Gatsby community, I wanted to say thank you for being here.

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (We’ve got t-shirts and hats, plus some socks that are really razzing our berries right now.)
  2. If you’re not already part of it, we just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If you have questions, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again! 💪💜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants