-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
require graphql import from gatsby to use #6002
Conversation
As a less severe change, we could also assume global i.e. unreferenced |
💯 to this so let's make this possible. Perhaps we deprecate auto-supporting the graphql tag in v2 and then require it in v3? |
Also 💯 to making the graphql tag seem less magical (even though it still will be under the hood). |
I can't seem to get a local test up running using this...lets see if netlify works nothing should break |
w/y/t ? |
I like it! For this maybe we could do some |
adding some robustness to this! |
ok this covers a lot more edge cases, I wanted to write the codemod as well but ran out of time... |
Looks great! Thanks for writing this! A number of people have complained about not being able to use Relay & Gatsby together and I think everyone has complained about |
I'll create a follow-up issue about updating the tutorial to account for this. Once we have a codemod, we can run that on the example sites to update them. |
This is a pretty big breaking change, and I can walk back some of it so it can be made compatible (like a config setting to require the import).
I need to make a gatsby site that works with relay/apollo on the client in the very near future but that isn’t possible at the moment because gatsby assumes all graphql tags are its own.