-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace react-router with @reach/router #6918
Merged
Merged
Changes from 12 commits
Commits
Show all changes
27 commits
Select commit
Hold shift + click to select a range
af1227c
Get @reach/router working probably in development
KyleAMathews e0f2bec
Moer stuff working
KyleAMathews 091ce37
Don't support to as an object
KyleAMathews 7a6c868
Add back support for activeClassName & activeStyle
KyleAMathews 48e3733
Fix path for RouteHandlers
KyleAMathews 874acf1
Pull in parse-path util from react-router
KyleAMathews a31706a
remove console.logs and add TODO
KyleAMathews 596796b
Merge remote-tracking branch 'origin/master' into reach-router
KyleAMathews 9b7e648
Remove now unused webpack rules to trim down react-router
KyleAMathews fed26d1
Some fixes from merge
KyleAMathews 65e7d86
Fix problems identified in review earlier
KyleAMathews 9db958c
Remove old typescript definitions
KyleAMathews 75ebf29
Merge remote-tracking branch 'origin/master' into reach-router
KyleAMathews 96c1c92
Restore and update the <Link> documentation for v2/@reach/router
KyleAMathews 33583a2
Also set the className when the site is active per @pieh's advice
KyleAMathews cee482f
Upgrade client-only-paths example site
KyleAMathews ad0b949
Upgrade simple-auth example site
KyleAMathews 11753c0
Fix lint errors
KyleAMathews 197ed0e
Merge remote-tracking branch 'origin/master' into reach-router
KyleAMathews 7c61690
Migration docs
KyleAMathews 8c0f084
Note that can't use relative routes w/ @reach/router
KyleAMathews 97ff092
Fix/remove tests that are irrelevant now
KyleAMathews 01b9959
Fix imports
KyleAMathews 4c7e80c
Use v2 version of children for layout
KyleAMathews bc7035c
mini typos
m-allanson ea00a10
Merge remote-tracking branch 'origin/master' into reach-router
KyleAMathews 06d9c77
Document that history prop no longer passed to page components
KyleAMathews File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to add default
className
(similiar how styles are merged in line below)react-router
'sNavLink
does that - https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/modules/NavLink.js#L41-L42 if we want to maintain backward compatibilityThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah good catch, fixed in 33583a2