Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace backslash in requirePath to slash #698

Closed
wants to merge 1 commit into from
Closed

Replace backslash in requirePath to slash #698

wants to merge 1 commit into from

Conversation

chenvan
Copy link

@chenvan chenvan commented Feb 28, 2017

It will cause error when there is a backslash in page.requirePath

It will cause error when there is a backslash in page.requirePath
@KyleAMathews
Copy link
Contributor

@chenvan hey I'm not sure this is the right way to fix this — perhaps the best place to start would be if you could add a PR with a new test that's failing on this issue. I'd like to poke at the issue a bit. You'll want to add a site fixture like those in https://github.com/gatsbyjs/gatsby/tree/master/test/fixtures

@chenvan
Copy link
Author

chenvan commented Mar 8, 2017

@KyleAMathews Ok, but I need time to figure out, I never do that before

@KyleAMathews
Copy link
Contributor

@chenvan this series of free Egghead lessons by @kentcdodds might help!

https://medium.com/@kentcdodds/introducing-how-to-contribute-to-open-source-be67917eb704#.l9kokzc0j

Feel free to ask questions. Don't feel bad about adding an incomplete Pull Request here. Just get something going and we can help you through the rest of the process.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants