Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change using-redux example to not use replaceRouterComponent API #6986

Merged
merged 1 commit into from
Aug 6, 2018

Conversation

pieh
Copy link
Contributor

@pieh pieh commented Aug 3, 2018

replaceRouterComponent API will be removed in #6918 and also it doesn't make sense to use this API for wrapping component tree if we have more appropiate API for it

@KyleAMathews
Copy link
Contributor

Deploy preview for using-postcss-sass failed.

Built with commit 39cfc6d

https://app.netlify.com/sites/using-postcss-sass/deploys/5b6451fe3813f03833b8f789

@pieh pieh mentioned this pull request Aug 3, 2018
@gatsbybot
Copy link
Collaborator

Deploy preview for using-drupal ready!

Built with commit 39cfc6d

https://deploy-preview-6986--using-drupal.netlify.com

@gatsbybot
Copy link
Collaborator

Deploy preview for gatsbygram ready!

Built with commit 39cfc6d

https://deploy-preview-6986--gatsbygram.netlify.com

@pieh
Copy link
Contributor Author

pieh commented Aug 3, 2018

Link to preview deploy of example to show it actually works - https://deploy-preview-6986--using-redux.netlify.com

Copy link
Contributor

@KyleAMathews KyleAMathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@KyleAMathews KyleAMathews merged commit 0b70e96 into gatsbyjs:master Aug 6, 2018
porfirioribeiro pushed a commit to porfirioribeiro/gatsby that referenced this pull request Aug 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants