Offline plugin fetch error #8158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtenfys
reviewed
Sep 14, 2018
| for (const resource of resources) { | ||
| fetch(resource) | ||
| a.href = resource |
There was a problem hiding this comment.
It would be better to use const a = new URL(resource) here - same effect but we don't need to create a hidden element
There was a problem hiding this comment.
Also might be better to rename this if it lo longer uses an <a> tag
vtenfys
reviewed
Sep 14, 2018
| for (const resource of resources) { | ||
| fetch(resource) | ||
| a.href = resource | ||
| const isExternal = (a.host && a.host !== window.location.host) |
There was a problem hiding this comment.
This should be .origin rather than .host since a URL is considered cross-origin if the port or protocol are different. Also, if we use new URL() as above then it guarantees the variable a has a .origin property, so the check can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
no-corsmode when fetching external resourcesThis 'fixes' #8145, although I don't really understand what was causing that issue. So maybe this will need some extra testing.