[gatsby-image] Restore placeholder image transition #8350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👀 taking a look |
|
Looks good from here too. |
DSchau
approved these changes
Sep 20, 2018
Successfully published:
- gatsby-image@2.0.7 |
lipis
added a commit
to lipis/gatsby
that referenced
this pull request
Sep 21, 2018
* master: (22 commits) Adding blog post link to readme (gatsbyjs#8397) [www] A bunch of mostly "Creator"-related UI updates (gatsbyjs#8390) Add Ramon Chancay Creator (gatsbyjs#8389) [www] Update LeKoArts' portfolio starters' info (gatsbyjs#8365) Add self to creators. (gatsbyjs#8391) Behind the scenes (gatsbyjs#8392) Add https://hawaiinational.bank to sites.yml (gatsbyjs#8394) Add Marc-Antoine Ruel to community page (gatsbyjs#8378) chore(release): Publish [gatsby-image] Restore placeholder image transition (gatsbyjs#8350) Add www.leyanlo.com to sites.yml (gatsbyjs#8363) Add Jest to v2 migration docs (gatsbyjs#8384) [www] Fix wire.com Showcase URL (gatsbyjs#8376) Update Creator Showcase and Site Showcase (gatsbyjs#8377) Created stub article for navigation doc Added new navigation docs to sidebar www: fix images on audit with lighthouse doc (gatsbyjs#8373) Fix link (gatsbyjs#8375) Updated links using gatsby image in sidebar nav ...
oorestisime
pushed a commit
to oorestisime/gatsby
that referenced
this pull request
Sep 28, 2018
In gatsbyjs#7083 the css `transition` was moved [from Img](https://github.com/gatsbyjs/gatsby/blob/bcf3af57f3b6438424b712ce1785a6a423b937da/packages/gatsby-image/src/index.js#L117) to [imageStyle](https://github.com/gatsbyjs/gatsby/blob/5ffb1307c17bef802026d5992e1ad000ff654f11/packages/gatsby-image/src/index.js#L224), leaving [imagePlaceholderStyle with a transitionDelay](https://github.com/gatsbyjs/gatsby/blob/5ffb1307c17bef802026d5992e1ad000ff654f11/packages/gatsby-image/src/index.js#L217), but without an actual transition. Although I don't follow everything that changed with that commit, I think that wasn't on purpose. @tbrannam can you confirm?
This was referenced Mar 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #7083 the css
transitionwas moved from Img to imageStyle, leaving imagePlaceholderStyle with a transitionDelay, but without an actual transition.Although I don't follow everything that changed with that commit, I think that wasn't on purpose. @tbrannam can you confirm?