Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update 'How Gatsby works doc': CNAME file should be copied in public folder #8430

Closed
wants to merge 1 commit into from

Conversation

angelogulina
Copy link

@angelogulina angelogulina commented Sep 21, 2018

Though the build process is working perfectly, it seems to me that, as suggested, theCNAME should be in the public folder in order to get into the right place for GitHub to recognize.

(I'm really new to this project so if I'm wrong, I would be glad to receive feedback if this PR is wrong 🙏)

@angelogulina angelogulina changed the title CNAME file should be copied in public folder Update 'How Gatsby works doc': CNAME file should be copied in public folder Sep 21, 2018
@LekoArts
Copy link
Contributor

Hi!
The issue you linked already has the right answer: Put it into the static folder as it gets copied over. Normally you don't have access to the public folder in a CI as Netlify anyway and therefore can't copy it over manually.
The docs also describe that:
https://www.gatsbyjs.org/docs/adding-images-fonts-files/#using-the-static-folder

Thanks for the PR though (I'll close this one)

@LekoArts LekoArts closed this Sep 21, 2018
@angelogulina
Copy link
Author

@LekoArts thanks for you reply.
I'm just curious: has anybody tried or experienced that anyway?
I'm hosting my website on gh pages since today and if I don't put the CNAME in public, it gets to static and github doesn't seem to find it.

@LekoArts
Copy link
Contributor

You need to put it into the static folder (same directory as your src folder) as described in the doc. I'm not talking about the static folder of the „gatsby build“!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants