Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: skip Mdx nodes without absolute file path #137

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

asterikx
Copy link

@asterikx asterikx commented Jul 1, 2021

Plugins such as gatsby-source-contentful also create nodes with internal type Mdx, but do not add an absolute file path. Skipping Mdx nodes without absolute file path (from which we can derive the locale) seems ok since Contentful already handles localization.

Plugins such as `gatsby-source-contentful` also create nodes with internal type `Mdx`, but do not add an absolute file path. Skipping Mdx nodes without absolute file path (from which we can derive the locale) seems ok since Contentful already handles localization.
Copy link

@paiou paiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mandatory fix for many source plugins.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants