Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make theme compatible to gatsby-plugin-mdx v4 #174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

EricCote
Copy link

@EricCote EricCote commented Sep 14, 2022

This pull request will solve #172.

I've also updated to React 18.

This is far from perfect. There issues with themes and Gatsby that are difficult to solve.

For now, themes cannot be compatible with the new "Head API". See gatsbyjs/gatsby#35841 (reply in thread) . Result: we need to stick with Helmet until v5 of Gatsby.

I hope that v5 of Gatsby has a better i18n story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant