feat(gatsby-theme-i18n): Localized matchPath & LocalizedRouter #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@aaaakshat would you mind merging this? Also, do you expect to release a version with this fix soon? It would really help us. |
bitmaks
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
Hey there, apologies but I'm not Gatsby staff. I was a maintainer when I merged your previous PR; however Gatsby recently underwent a organisational restructure (blog post here).
The new structure will only let Gatsby staff handle write access to repos so someone from the team should hopefully review this soon.
LekoArts
changed the title
|
Thanks for the PR! I added example code to the default example and also added a I'll release this on monday then! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://www.gatsbyjs.com/docs/gatsby-internals-terminology/#matchpath
the matchPath prop on the page being created was not being modified (by adding /langCode/ to the start of matchPath)
This would cause client pages not being properly found and when accessing
/langCode/client-page-url