fixed marker being saved under wrong key in marker cache #531
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently pagination is broken for backends that use opaque markers. It is so because the key (
last key from the set
) under which a real marker is saved is different than the key (encoded marker
) that S3Proxy is trying to use to read a real marker.It results with S3Proxy being able to fetch only 1 page:
This could be solved by either using
last key from the set
as a marker in response or usingencoded nextMarker
as part of key in cache. In this PR I decided to implement the second solution.