Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test TestFormatter_FailureContext #262

Closed
gavv opened this issue Feb 1, 2023 · 5 comments
Closed

Add unit test TestFormatter_FailureContext #262

gavv opened this issue Feb 1, 2023 · 5 comments
Assignees
@frankweate
Labels
help wanted Contributions are welcome important Important task tests Improvements or additions to tests
Milestone
v2

Comments

@gavv
Copy link
Owner

gavv commented Feb 1, 2023

Add unit test that checks how DefaultFormatter builds FormatData from AssertionContext and how formatting options affect this.

The test should fill AssertionContext fields (TestName, RequestName, Path, AliasedPath), set formatting options in DefaultFormatter, and invoke DefaultFormatter.buildFormatData, similar to TestFormatter_Failure* tests.

In retrieved FormatData struct it should check fields that correspond to AssertionContext fields.

It should check the following formatting options:

  • DisableNames
  • DisablePaths
  • DisableAliases

Related: #165
@gavv gavv added tests Improvements or additions to tests help wanted Contributions are welcome labels Feb 1, 2023
@gavv gavv mentioned this issue Feb 1, 2023
Closed
@gavv gavv changed the title Add unit test for FormatData Add unit test for AssertionContext and FormatData Feb 1, 2023
@gavv gavv changed the title Add unit test for AssertionContext and FormatData Add unit test TestFormatter_FailureContext Feb 1, 2023
@gavv gavv mentioned this issue Feb 1, 2023
Closed
@gavv gavv pinned this issue Apr 4, 2023
@gavv gavv added the important Important task label Apr 8, 2023
@frankweate
Copy link
Contributor

Hi gavv! Could I have a go at this?

@gavv
Copy link
Owner Author

gavv commented Apr 27, 2023

Sure, thanks!

@vasundhara785 vasundhara785 mentioned this issue May 1, 2023
Merged
@frankweate
Copy link
Contributor

@gavv I was half way through working on this issue, I'll stop working on this? I'm happy to find other issues to work on!

@aliziyacevik
Copy link
Contributor

hi @gavv, can I give it a go ?

@gavv
Copy link
Owner Author

gavv commented Oct 1, 2023

Landed.

@frankweate Sorry for late reply and for inconvenience. I have just merged #418. Thanks anyway!

@aliziyacevik Thanks, I have merged existing PR.

@gavv gavv closed this as completed Oct 1, 2023
@gavv gavv unpinned this issue Oct 2, 2023
@gavv gavv added this to the v2 milestone Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@frankweate frankweate

Labels
help wanted Contributions are welcome important Important task tests Improvements or additions to tests
Projects
None yet
Milestone
v2
Development

No branches or pull requests
3 participants
@gavv @frankweate @aliziyacevik