Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit test TestFormatter_FailureErrors #264

Closed
gavv opened this issue Feb 1, 2023 · 2 comments · Fixed by #317
Closed

Add unit test TestFormatter_FailureErrors #264

gavv opened this issue Feb 1, 2023 · 2 comments · Fixed by #317
Assignees
@Darrellbor
Labels
good first issue Good for newcomers help wanted Contributions are welcome tests Improvements or additions to tests
Milestone
v2

Comments

@gavv
Copy link
Owner

gavv commented Feb 1, 2023 •
edited
Loading

This test should check how DefaultFormatter handles Errors field of the failure. It's similar to other TestFormatter_Failure* tests.

It should check the following cases:

  • nil Errors slice
  • non-nil empty Errors slice
  • Errors slice with nil error
  • Errors slice with typed nil error
  • Errors slice with one error
  • Errors slice with multiple errors

For each case, we should call buildFormatData and check FormatData.Errors.

Related: #165, #262
@gavv gavv added tests Improvements or additions to tests help wanted Contributions are welcome good first issue Good for newcomers labels Feb 1, 2023
@gavv gavv mentioned this issue Feb 1, 2023
Closed
@Darrellbor
Copy link
Contributor

@gavv i'd like to help out with this issue

@gavv
Copy link
Owner Author

gavv commented Feb 24, 2023

You're welcome!

@Darrellbor Darrellbor mentioned this issue Mar 1, 2023
Merged
6 tasks
@gavv gavv linked a pull request Mar 3, 2023 that will close this issue
Unit test TestFormatter_FailureErrors #317
Merged
6 tasks
@gavv gavv closed this as completed in #317 Mar 5, 2023
@gavv gavv added this to the v2 milestone Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Darrellbor Darrellbor

Labels
good first issue Good for newcomers help wanted Contributions are welcome tests Improvements or additions to tests
Projects
None yet
Milestone
v2
Development

Successfully merging a pull request may close this issue.

Unit test TestFormatter_FailureErrors Darrellbor/httpexpect
2 participants
@gavv @Darrellbor