Add DefaultFormatter.DisableScientific #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update unit test of float32 on disable scientific.
This comment was marked as resolved.
This comment was marked as resolved.
gavv
reviewed
Jan 2, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Update documentation of DisableScientific.
Separate DisableScientific unit test.
Remove unused fields in unit test.
This comment was marked as resolved.
This comment was marked as resolved.
gavv
reviewed
Jan 10, 2023
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
gavv
reviewed
Jan 21, 2023
|
The updated test looks good. Also it would be nice to cover these cases:
What else? I guess only #220 (comment) ? |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
Remove isFloat because extractFloat has the same responsibility.
With FloatFormat we can decide to print float in decimal, scientific notation, or auto.
Line too long.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
gavv
reviewed
Jan 24, 2023
gavv
force-pushed
the
master
branch
2 times, most recently
from
43b0a86
to
ee27d9f
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Update comments related to FloatFormat.
… 190-default-formatter-disable-scientific
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
this MR is now ready @gavv |
gavv
added
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #190
Tasks:
Add/update remaining unit test (if sample is ok)Complete unit test with other assertion types (e.g.formatting of AssertionList with numberas mentioned in Add DefaultFormatter.DisableScientific #220 (comment))