Colorize json values #334 #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for PR! Will review in upcoming days. |
|
☔ The latest upstream change (presumably these) made this pull request unmergeable. Please resolve the merge conflicts. |
github-actions
bot
added
the
needs rebase
|
Thanks for PR and sorry for delay! I've rebased your patch and merged it manually: 089b33d Problems with tests on Windows were already addressed in another PR, so I excluded this change. Also here is small follow-up commit: 0895176 I did a few renames, changed coloring a bit, and fixed indentation. Now it looks like this:
Thank you! |
gavv
removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#334
@gavv Hey this is my first attempt to contribute :)
I would appreciate any feedback and guidance a lot!
Thanks and best wishes