Enable passing function or misc slots to the use argument in selection functions #173 #174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregorgorjanc
commented
Jan 19, 2024
| if(is(pop,"HybridPop")){ | ||
| stop("Use='bv' is not a valid option for HybridPop") | ||
| if(is.character(use)){ | ||
| use = tolower(use) |
There was a problem hiding this comment.
I had to move use = tolower(use) and rand part within the if and else block since use can now be a character or a function.
gregorgorjanc
commented
Jan 19, 2024
| if(is(pop,"HybridPop")){ | ||
| stop("Use='bv' is not a valid option for HybridPop") | ||
| if(is.character(use)){ | ||
| use = tolower(use) |
There was a problem hiding this comment.
I had to move use = tolower(use) and rand part within the if and else block since use can now be a character or a function.
gregorgorjanc
commented
Jan 19, 2024
| response = genParam(pop,simParam=simParam)$bv | ||
| response = trait(response,...) | ||
| }else if(is(use,"function")){ | ||
| response = trait(use(pop, ...), ...) |
There was a problem hiding this comment.
This should enable max flexibility where both trait and use are a function
gregorgorjanc
commented
Jan 19, 2024
| } | ||
| response = genParam(pop,simParam=simParam)$bv[,trait,drop=FALSE] | ||
| }else if(is(use,"function")){ | ||
| response = use(pop, trait=trait, ...) |
There was a problem hiding this comment.
I think this will be the most common case when use is a function. We likely don't need to really pass trait to use() but for consistency/flexibility I felt it's probably best.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #173
I have implemented this proposal, documented, and tested it.
I look forward to comments! I will provide some notes by commenting some lines of code - see in the conversation.