Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ign ➡️ gz #109

Closed
wants to merge 5 commits into from
Closed

ign ➡️ gz #109

wants to merge 5 commits into from

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented May 17, 2022

@chapulina
Copy link
Contributor Author

I started trying to fix Windows CI using this branch on gazebo-tooling/release-tools@master...chapulina/gazebodistro_gz, but I'm starting to wonder if we shouldn't just move all files and change all directory names (even not Garden).

Maintaining a single format will be easier in the long run. The downside is potentially breaking users of versions < Garden that rely on gazebodistro - but we've never promised this would be stable, so I think it may be worth the change.

Any thoughts, @j-rivero ?

@chapulina chapulina mentioned this pull request Jun 7, 2022
@chapulina chapulina changed the base branch from master to chapulina/URLs June 7, 2022 19:59
Base automatically changed from chapulina/URLs to master June 7, 2022 21:19
chapulina added 5 commits June 7, 2022 14:20
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@methylDragon
Copy link
Contributor

LGTM! We'll need to remember to gz-gazebo7.yaml -> gz-sim7.yaml once we migrate the project names though

@chapulina chapulina marked this pull request as draft July 25, 2022 16:50
@j-rivero
Copy link
Contributor

j-rivero commented Aug 2, 2022

but I'm starting to wonder if we shouldn't just move all files and change all directory names (even not Garden).

Maintaining a single format will be easier in the long run. The downside is potentially breaking users of versions < Garden that rely on gazebodistro - but we've never promised this would be stable, so I think it may be worth the change.

I found the same blocker while testing gazebo-tooling/release-tools#738 and #112. It would be great if we use the same names for all the files and at the same time maintain the current file names, something that we could probably accomplish on UNIX using symlinks. On Windows I would prefer to skip the symlink management so the option could be to duplicate the old files (previous to Garden) to have ign- and gz- with the obvious cost of maintenance and introducing a possible source of problems. I'm only proposing this since these files rarely change but I can be convinced otherwise.

@j-rivero
Copy link
Contributor

j-rivero commented Aug 3, 2022

Let's follow in #117

@j-rivero j-rivero closed this Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants