Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nightlies for all main branches #50

Merged
merged 1 commit into from
Dec 29, 2021
Merged

Conversation

chapulina
Copy link
Contributor

Revisiting an idea which was originally introduced in #31, but eventually reverted.

  • Current approach: use nightlies when a main branch is known to go into the upcoming collection
    • Cons:
      • It's one more PR to open as part of a dependency bumping process, which is already complicated as it is
      • We often refrain from adding the nighlies for a main branch while bumping if we know that it won't be immediately necessary. This means we need to track it back when it is necessary, causing more churn. See Use nightlies on new Fortress branches #31
    • Pros:
      • Only use nightlies when strictly necessary, so if we see nightlies enabled, we know they're needed
  • Suggestion: use nightlies for all main branches

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina merged commit 5812356 into master Dec 29, 2021
@chapulina chapulina deleted the chapulina/main/nightlies branch December 29, 2021 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants