Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cross-platform python script to check for ci_matching_branch names #579

Closed
scpeters opened this issue Dec 3, 2021 · 0 comments · Fixed by #583
Closed

Add cross-platform python script to check for ci_matching_branch names #579

scpeters opened this issue Dec 3, 2021 · 0 comments · Fixed by #583

Comments

@scpeters
Copy link
Contributor

scpeters commented Dec 3, 2021

As part of #564, portions of our CI infrastructure will try to checkout matching branch names if the branch name contains ci_matching_branch/ (gzdev in #572 and homebrew-simulation in #575). @j-rivero requested in #575 (comment) that we avoid duplicating the ci_matching_branch/ string in different scripts.

I propose adding a python script that takes a string as an input and compares it to the hard-coded regex. This would be similar to our detect_cmake_major_version.py script that we use on multiple platforms.
@scpeters scpeters mentioned this issue Dec 3, 2021
Merged
scpeters added a commit that referenced this issue Dec 3, 2021
@scpeters
Add python tool to check for matching CI branches
ca71c0d 
Fixes #579.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Dec 3, 2021
Merged
scpeters added a commit that referenced this issue Dec 3, 2021
@scpeters
Add python tool to check for matching CI branches
ee885fd 
Fixes #579.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this issue Dec 4, 2021
@scpeters
Add python tool to check for matching CI branches (#583)
be8a55a 
Use in windows CI to try matching gazebodistro branch.

Fixes #579.
Part of #564.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters mentioned this issue Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add python tool to check for matching CI branches gazebo-tooling/release-tools
1 participant
@scpeters