Include a script to obtain gazebo releases for a given library #1148
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
jenkins-scripts/dsl/tools/README.md
Outdated
| contains a given library and major version that are provided as input | ||
| parameters. | ||
|
|
||
| The output is provid |
There was a problem hiding this comment.
ouch fixed 02f5612
jenkins-scripts/dsl/tools/README.md
Outdated
| Nothing if not found.ed as a space separated list in a single line. | ||
| Nothing if not found. |
There was a problem hiding this comment.
I think a sentence is repeated here.
There was a problem hiding this comment.
fixed also here 02f5612
| if len(sys.argv) < 3: | ||
| print(f"Usage: {sys.argv[0]} <lib_name> <major_version> <collection-yaml-file>") | ||
| sys.exit(1) | ||
|
|
||
| lib_name = sys.argv[1] | ||
| version = sys.argv[2] | ||
| yaml_file = sys.argv[3] | ||
|
|
||
| with open(yaml_file, 'r') as file: | ||
| data = yaml.safe_load(file) | ||
|
|
||
| collection_names = find_collection(data, lib_name, get_major_version(version)) | ||
| print(f"{' '.join(collection_names)}") |
There was a problem hiding this comment.
Consider putting this in an if __main__ block so this module can be imported by other Python code in the future
There was a problem hiding this comment.
Implemented the main and other improvements 3c62cde
|
|
||
|
|
||
| if len(sys.argv) < 3: | ||
| print(f"Usage: {sys.argv[0]} <lib_name> <major_version> <collection-yaml-file>") |
There was a problem hiding this comment.
I won't block on this, but my preference would be to put more of the usage info in here rather than README.md. Users are accustomed to running a script or running with -h to see usage information.
There was a problem hiding this comment.
That is also a good point but given that this repo uses README descriptions extensively, I'm going to to keep it consistent and store the details in as they are in the file.
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
A helper script to obtain the Gazebo collection/releases given a library and a major version. It uses the gz-collections.yaml as the database to search for the metadata.