Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli11 to VCPKG_DEPENDENCIES_LEGACY and Conda legacy env #1230

Merged
merged 2 commits into from
Jan 21, 2025

Conversation

scpeters
Copy link
Contributor

Needed by gazebosim/gz-utils#167.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@j-rivero
Copy link
Contributor

Version in our vcpkg snapshot is "2.1.2" https://github.com/microsoft/vcpkg/blob/2022.02.23/ports/cli11/vcpkg.json. Is it good enough? We have the same version available in Conda.

Signed-off-by: Jose Luis Rivero <jrivero@honurobotics.com>
@j-rivero j-rivero changed the title Add cli11 to VCPKG_DEPENDENCIES_LEGACY Add cli11 to VCPKG_DEPENDENCIES_LEGACY and Conda legacy env Jan 10, 2025
@scpeters
Copy link
Contributor Author

Version in our vcpkg snapshot is "2.1.2" https://github.com/microsoft/vcpkg/blob/2022.02.23/ports/cli11/vcpkg.json. Is it good enough? We have the same version available in Conda.

the current vendored version is 1.9.1, so yes I think 2.1.2 is good enough

@scpeters
Copy link
Contributor Author

still waiting for an approval for this

@scpeters scpeters merged commit 343aad7 into master Jan 21, 2025
1 check passed
@scpeters scpeters deleted the scpeters/vcpkg_cli11 branch January 21, 2025 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants