Add sdf12 to ABI checker #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
azeey
commented
Sep 30, 2021
jenkins-scripts/dsl/sdformat.dsl
Outdated
| def sdformat_supported_branches = [ 'sdformat6' , 'sdformat9', 'sdformat10', 'sdformat11' ] | ||
| def sdformat_gz11_branches = [ 'sdformat9', 'sdformat10', 'sdformat11', 'main' ] | ||
| def sdformat_supported_branches = [ 'sdformat6' , 'sdformat9', 'sdformat10', 'sdformat11', 'sdformat12' ] | ||
| def sdformat_gz11_branches = [ 'sdformat9', 'sdformat10', 'sdformat11', 'sdformat12, 'main' ] | ||
| // nightly and prereleases | ||
| def extra_sdformat_debbuilder = [ 'sdformat12' ] |
There was a problem hiding this comment.
I don't know if we're supposed to remove sdformat12 from extra_sdformat_debbuilder or not.
There was a problem hiding this comment.
I think it could be removed
There was a problem hiding this comment.
Ok, removed in ec24312
scpeters
reviewed
Sep 30, 2021
jenkins-scripts/dsl/sdformat.dsl
Outdated
| def sdformat_supported_branches = [ 'sdformat6' , 'sdformat9', 'sdformat10', 'sdformat11' ] | ||
| def sdformat_gz11_branches = [ 'sdformat9', 'sdformat10', 'sdformat11', 'main' ] | ||
| def sdformat_supported_branches = [ 'sdformat6' , 'sdformat9', 'sdformat10', 'sdformat11', 'sdformat12' ] | ||
| def sdformat_gz11_branches = [ 'sdformat9', 'sdformat10', 'sdformat11', 'sdformat12, 'main' ] |
There was a problem hiding this comment.
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
scpeters
approved these changes
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by gazebosim/sdformat#724