Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So there's no use for
PULL_REQUEST_URL
anymore? Should it be removed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not used in this job, but I think it is used in a downstream job that updates the bottle hash
sha256
valuesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
confirmed that it is still in use in the downstream job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I read correctly the DSL code:
Looks to me like we are overriding
PULL_REQUEST_URL
value to the base URL +ghprbPullId
instead of using the current one in this script (injected bycurrentBuild()
.If we remove
PULL_REQUEST_URL
from here, is there anyway of launching the job manually? Can that be done without these changes? Maybe is not a supported use case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, maybe some of this logic is left over from when
release.py
could trigger a bottle build and would passPULL_REQUEST_URL
. Now we only start bottle builds from GitHub comments. I'll see if there's something that should be removedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's not easy to start the "bottle hash updater job" manually since it needs artifacts from a bottle build
I looked and I don't think there's anything more to be changed