Use ci_matching_branch/ in bump_dependency.bash #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part of #564. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Replace branch name before swapping - for _ in DEP_LIB. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
The source code PRs will fail without the metadata, so commit the metadata first. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
bump_dependency.bashscript to prefix branch names withci_matching_branch/so that CI should automatically use the matching branch in infrastructure repositories. I'm using this branch with #554, and branch matching currently works forhomebrew-simulation, so I would expect the homebrew builds to work properly.The following changes support the matching branch names:
ci_matching_branch/prefixbump_The following fixes a bug in fuel-tools branch name replacement:
-for_substitution in the search/replace for collection repositories since it didn't replaceign-fuel-tools8withmainproperlyI've also re-ordered the pull requests so that metadata pull requests should be opened first. I think the CI jobs will be more likely to pass with this approach.