Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gazebo.dsl: use 20.04 for pull request CI builds #854

Merged
merged 1 commit into from
Dec 13, 2022

Conversation

scpeters
Copy link
Contributor

We can switch to 20.04 for gazebo-classic CI when the fix for gazebo9 is merged in gazebosim/gazebo-classic#3278, which will resolve the issue gazebosim/gazebo-classic#3151.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from j-rivero as a code owner November 15, 2022 06:53
@j-rivero
Copy link
Contributor

Only in /tmp/current_xml_configuration: gazebo-ci-coverage-bionic-amd64-gpu-nvidia.xml
Only in /tmp/pr_xml_configuration: gazebo-ci-coverage-focal-amd64-gpu-nvidia.xml
Only in /tmp/current_xml_configuration: gazebo-ci-gazebo11-bionic-amd64-gpu-nvidia.xml
Only in /tmp/current_xml_configuration: gazebo-ci-gazebo11-bionic-i386-gpu-none.xml
Only in /tmp/pr_xml_configuration: gazebo-ci-gazebo11-focal-amd64-gpu-nvidia.xml
Only in /tmp/pr_xml_configuration: gazebo-ci-gazebo11-focal-i386-gpu-none.xml
Only in /tmp/current_xml_configuration: gazebo-ci-gazebo9-bionic-amd64-gpu-nvidia.xml
Only in /tmp/pr_xml_configuration: gazebo-ci-gazebo9-focal-amd64-gpu-nvidia.xml
Only in /tmp/current_xml_configuration: gazebo-ci-pr_any+sdformat_any+ign_any-bionic-amd64-gpu-nvidia.xml
Only in /tmp/pr_xml_configuration: gazebo-ci-pr_any+sdformat_any+ign_any-focal-amd64-gpu-nvidia.xml
diff -ur -I '.*<id>dashboard_portlet_.*</id>.*' /tmp/current_xml_configuration/gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-nvidia.xml /tmp/pr_xml_configuration/gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-nvidia.xml
--- /tmp/current_xml_configuration/gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-nvidia.xml	2022-11-15 06:55:20.022322680 +0000
+++ /tmp/pr_xml_configuration/gazebo-ci-pr_any-ubuntu_auto-amd64-gpu-nvidia.xml	2022-11-15 06:53:45.710641098 +0000
@@ -88,7 +88,7 @@
         <hudson.tasks.Shell>
             <command>#!/bin/bash -xe
 
-export DISTRO=bionic
+export DISTRO=focal
 
 export ARCH=amd64
 export GPU_SUPPORT_NEEDED=true
Only in /tmp/current_xml_configuration: gazebo-ci_BTCoverage-gazebo11-bionic-amd64-gpu-none.xml
Only in /tmp/pr_xml_configuration: gazebo-ci_BTCoverage-gazebo11-focal-amd64-gpu-none.xml
Only in /tmp/current_xml_configuration: gazebo-ci_BTDebug-gazebo11-bionic-amd64-gpu-none.xml
Only in /tmp/pr_xml_configuration: gazebo-ci_BTDebug-gazebo11-focal-amd64-gpu-none.xml
Only in /tmp/current_xml_configuration: gazebo-ci_BTRelease-gazebo11-bionic-amd64-gpu-none.xml
Only in /tmp/pr_xml_configuration: gazebo-ci_BTRelease-gazebo11-focal-amd64-gpu-none.xml
Only in /tmp/current_xml_configuration: gazebo-install-gazebo11_pkg-bionic-amd64.xml
Only in /tmp/pr_xml_configuration: gazebo-install-gazebo11_pkg-focal-amd64.xml
Only in /tmp/current_xml_configuration: gazebo-install-gazebo9_pkg-bionic-amd64.xml
Only in /tmp/pr_xml_configuration: gazebo-install-gazebo9_pkg-focal-amd64.xml

@j-rivero
Copy link
Contributor

Note that this change is going to break the CI series for stable branches since new jobs will be created leaving the others disabled, unless we manually rename the old ones. If we rename manually the jobs to match new ones, the current existing links pointing there will be broken but might be a better alternative.

We also need a corresponding PR for buildfarmers @Blast545 @Crola1702. You can see the current names under the text "Only in /tmp/current_xml_configuration" and the new ones using "Only in /tmp/pr_xml_configuration" in the comment above this one.

@scpeters
Copy link
Contributor Author

my main short-term goal is to switch the pull request CI to 20.04, but it will be needed when 18.04 reaches EOL next year

@j-rivero
Copy link
Contributor

Changed job names using Jenkins console // @Crola1702

 = Job gazebo-ci-gazebo11-focal-amd64-gpu-nvidia exists!
 * gazebo-ci-gazebo11-bionic-i386-gpu-none ----> gazebo-ci-gazebo11-focal-i386-gpu-none
 * gazebo-ci_BTCoverage-gazebo11-bionic-amd64-gpu-none ----> gazebo-ci_BTCoverage-gazebo11-focal-amd64-gpu-none
 * gazebo-ci_BTDebug-gazebo11-bionic-amd64-gpu-none ----> gazebo-ci_BTDebug-gazebo11-focal-amd64-gpu-none
 * gazebo-ci_BTRelease-gazebo11-bionic-amd64-gpu-none ----> gazebo-ci_BTRelease-gazebo11-focal-amd64-gpu-none
 * gazebo-install-gazebo11_pkg-bionic-amd64 ----> gazebo-install-gazebo11_pkg-focal-amd64
  = Job gazebo-install-gazebo9_pkg-focal-amd64 exists!
  = Job gazebo-ci-gazebo9-focal-amd64-gpu-nvidia exists!
 * gazebo-ci-coverage-bionic-amd64-gpu-nvidia ----> gazebo-ci-coverage-focal-amd64-gpu-nvidia

@j-rivero j-rivero merged commit 4359589 into master Dec 13, 2022
@j-rivero j-rivero deleted the scpeters/gazebo_focal_ci branch December 13, 2022 00:54
@Crola1702
Copy link
Contributor

Crola1702 commented Dec 13, 2022

@j-rivero ros2_gazebo_pkgs-install_pkg_rolling-jammy-amd64 was downgraded to ros2_gazebo_pkgs-install_pkg_rolling-focal-amd64 right?

@j-rivero
Copy link
Contributor

@j-rivero ros2_gazebo_pkgs-install_pkg_rolling-jammy-amd64 was downgraded to ros2_gazebo_pkgs-install_pkg_rolling-focal-amd64 right?

Not sure if that was a bug, it was not on propose. The list of jobs currently produced by the DSL code does not display that job https://build.osrfoundation.org/job/_dsl_gazebo_ros_pkgs/947/console so was probably a left over of some test or similar. The focal job builds seems to have been using focal for some time: https://build.osrfoundation.org/job/ros2_gazebo_pkgs-install_pkg_rolling-focal-amd64/364/console#console-section-2

We probably need to update the DSL code if we are interested into having that rolling + jammy job back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants