Change Infinite scroll to Pagination #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to remove the Infinite Scroll dependency, mainly due to this issue.
Now lists are paginated using the same approach as the server. At the bottom of each list, users can go to the next (or previous) pages, as well as select the items per page they want to see.
Most of these page changes will be reflected in the client's URL. For example: https://app.gazebosim.org/fuel/worlds?page=2&per_page=20.
Some lists' changes are not reflected on the client URL though. These are mainly lists within other components, such as a Collection's Models and/or Worlds, or the collections a model or world belongs to.
Most of the changes lie inside the
gz-fuel-resource-listcomponent, as well as changes in the Services used to get the list of resources.This is the last step towards updating the app to Angular 14.
Can you ptal @nkoenig ? Let me know if you have any question.
Screenshot
Note: Showing
http://localhost:3000/fuel/models?page=2&per_page=20with the Staging Server.