Make NewFirestoreRepository receive the collection name

[marcoshuck]

No description provided.

[AlejoAsd]

Isn't the collection name part of the Model passed in as a generic parameter?

[marcoshuck]

Isn't the collection name part of the Model passed in as a generic parameter?

Yes, but what if you ever want to use a different collection name with the same model? I think that when we designed the Model interface, we didn't take that use case into account.

However, I'm still running some tests with the e2e suite for listing solutions, will let you know if I end up needing a review on this.

[AlejoAsd]

In that case I would suggest creating a Model implementation that can you can specify a collection name for, and have the TableName() (which admittedly is a very SQL-centric name) return the collection name for it.

In short: this is a problem to solve at the Model level, not at the repository level.

[marcoshuck]

In that case I would suggest creating a Model implementation that can you can specify a collection name for, and have the TableName() (which admittedly is a very SQL-centric name) return the collection name for it.

In short: this is a problem to solve at the Model level, not at the repository level.

It's not that easy, because we're using the model as a generic T type in the Firestore repository, no place where to initialize it.

[AlejoAsd]

Great point. This is one of the shortcomings of generics unfortunately. I'm inclined to remove the generic part and just use reflection instead of a mixed approach as we need to interact with the type itself.

Let's go ahead with this approach for now.