Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tutorial to run sanitizer on ignition #149

Merged
merged 2 commits into from
Feb 26, 2021
Merged

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Feb 22, 2021

Signed-off-by: ahcorde ahcorde@gmail.com

While I was fixing a test on ign-gazebo I ended up finding some issues with the destructors in ignition-physics (DART), so I decided to run ASan/TSan to check if this tool may help me to debug the issue. In process I found several issues across some packages. This tutorial may help to reproduce my results.

🎉 Tutorial

Summary

Tutorial about how to run sanitizer (ASan/TSan) in a Igntiion workspace

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from chapulina February 22, 2021 08:04
@ahcorde ahcorde requested a review from maryaB-osr as a code owner February 22, 2021 08:04
@ahcorde ahcorde self-assigned this Feb 22, 2021
@chapulina chapulina added the documentation Improvements or additions to documentation label Feb 22, 2021
@chapulina chapulina requested a review from j-rivero February 22, 2021 19:36
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will come in handy! I only have minor comments, feel free to merge once they're addressed.

contributing.md Outdated Show resolved Hide resolved
contributing.md Outdated Show resolved Hide resolved
contributing.md Outdated Show resolved Hide resolved
Signed-off-by: ahcorde <ahcorde@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants