Use new policy for CMP0057 to fix finding DART #2835
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DARTFindBullet.cmake module uses the IN_LIST keyword with new behavior, which requires setting CMP0057 to new. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
5 tasks
|
we may not need this if dartsim/dart#1494 is released upstream first |
that has been merged and released upstream in dart 6.9.4, and I've confirmed that it has fixed the issue: this PR is no longer needed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of DART 6.9.3, the DARTFindBullet.cmake module uses the
IN_LISTkeyword with new behavior, which requires setting CMP0057 to new. Without this change, the gazebo10 CI is failing: