Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Forward Port Gazebo 11] Publish performance metrics (#2819) #2848

Merged
merged 1 commit into from
Sep 30, 2020
Merged

[Forward Port Gazebo 11] Publish performance metrics (#2819) #2848

merged 1 commit into from
Sep 30, 2020

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 28, 2020

Forward Port to Gazebo 11 - Publish performance metrics

Signed-off-by: ahcorde ahcorde@gmail.com
Co-authored-by: Ian Chen ichen@osrfoundation.org

@ahcorde @iche033
[Gazebo 9] Publish performance metrics (#2819)
7d00a3f 
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: Ian Chen <ichen@osrfoundation.org>

Co-authored-by: Ian Chen <ichen@osrfoundation.org>
@ahcorde ahcorde added the 11 Gazebo 11 label Sep 28, 2020
@ahcorde ahcorde requested a review from iche033 September 28, 2020 08:14
@ahcorde ahcorde self-assigned this Sep 28, 2020
@iche033
Copy link
Contributor

iche033 commented Sep 29, 2020

@osrf-jenkins run tests please

@iche033
Copy link
Contributor

iche033 commented Sep 30, 2020

works for me.

The last couple of jenkins windows builds failed due to an issue with the machine itself. Triggering another one..

@ahcorde
Copy link
Contributor Author

ahcorde commented Sep 30, 2020

@osrf-jenkins run tests please

@iche033
Copy link
Contributor

iche033 commented Sep 30, 2020

windows build finished. I think there is an issue with gazebo's window build in general. The jenkins report shows 2 tests failures but the console output shows: 1% tests passed, 389 tests failed out of 392 :( Looks like it's also happening in previous builds so not introduced by this PR.

chapulina
chapulina approved these changes Sep 30, 2020
View reviewed changes
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't ran it, but it looks like the one on Gazebo 9 and CI is ok.

@chapulina chapulina merged commit b9d40cc into gazebo11 Sep 30, 2020
@chapulina chapulina deleted the ahcorde/forwardport/2819 branch September 30, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@iche033 iche033 iche033 approved these changes

Assignees

@ahcorde ahcorde

Labels
11 Gazebo 11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ahcorde @iche033 @chapulina