Update TinyOBJLoader to v2.0.0rc8 #2885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
j-rivero
reviewed
Nov 20, 2020
There was a problem hiding this comment.
Did not find anything wrong in the PR or in the TinyOBJLoader bump. We can update changelog in this PR (unless you plan to update it with the changes for making the files with spaces to work):
diff --git a/Changelog.md b/Changelog.md
index 37a5d4c38a..cb80e23f18 100644
--- a/Changelog.md
+++ b/Changelog.md
@@ -5,6 +5,9 @@
1. Fix physics based sensor update rate in lockstep mode
* [Pull request #2863](https://github.com/osrf/gazebo/pull/2863)
+1. Updated the version of TinyOBJLoader from 1.0.0 to 2.0.0rc8.
+ * [Pull request #2885](https://github.com/osrf/gazebo/pull/2885)
+
## Gazebo 9.15.0 (2020-09-30)
1. More enhancement for Windows buildI'm compiling the beast to give it a quick try before approve it.
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
force-pushed
the
chapulina/9/tinyobj
branch
from
763da38 to
c81e2d9
Compare
No problem. I did not find any problem on the runtime manual test. All the failing tests seems not related to the ones involved in this PR, specially factory and obj_loader. Nice work. |
j-rivero
approved these changes
Nov 22, 2020
chapulina
added a commit
that referenced
this pull request
Nov 23, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
chapulina
added a commit
that referenced
this pull request
Nov 25, 2020
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of #2877, resolves #2870.
This completes the support of files containing white spaces. The support for referring to MTL files with spaces from OBJ files has been added to TinyOBJLoader on tinyobjloader/tinyobjloader#285 and is staged to be released into their 2.0.0 version.
I don't think it's a great idea to use a release candidate, but it looks like the
v2.0.0rc8tag doesn't break any of our existing use cases and brings lots of new features.The only API change from the revision we were previously using was the addition of warning messages, and that was added back in
v1.3.0, so it's not an artifact of bumping the major version.