-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compile test plugins as MODULE instead of STATIC #2897
Conversation
we still need to test with ARM, but just looking at our other supported platforms, I believe this has fixed the tests on Ubuntu amd64, but the macOS tests are still broken. apparently
we don't need to block this PR on macOS; if it fixes Ubuntu amd64 and ARM, we can add some comments to #800 about this and follow up later |
Interesting. I agree on following on #800. |
@j-rivero I just merged with |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
I started another job but it didn't finish https://build.osrfoundation.org/job/_test_gazebo-ci-pr_any-ubuntu_auto-arm64-gpu-nvidia/4/ |
it's looking better; the arm build succeeded, though there are more test failures than normal and the console output suggests a runtime problem
https://build.osrfoundation.org/job/_test_gazebo-ci-pr_any-ubuntu_auto-arm64-gpu-nvidia/7/ the windows build is failing though
https://build.osrfoundation.org/job/gazebo-ci-pr_any-windows7-amd64/3203/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for all the iteration and fixing the changelog!
Revert part of #2753 which change the compilation of plugins to STATIC.
Should fix #2883 in the gazebo11 branch. Needs to be tested on ARM.