Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile test plugins as MODULE instead of STATIC #2897

Merged
merged 7 commits into from
May 8, 2021
Merged

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Dec 4, 2020

Revert part of #2753 which change the compilation of plugins to STATIC.

Should fix #2883 in the gazebo11 branch. Needs to be tested on ARM.

@scpeters
Copy link
Member

scpeters commented Dec 6, 2020

we still need to test with ARM, but just looking at our other supported platforms, I believe this has fixed the tests on Ubuntu amd64, but the macOS tests are still broken. apparently MODULE libraries have a .so suffix on macOS (while shared libraries end with .dylib, see #800 and this stackover answer), so I think we'll need to update the logic in Plugin.hh in order to load .so files as plugins on macOS

[ 53%] Linking CXX shared module libExceptionModelPluginConstructor.so
...
[ 53%] Linking CXX shared module libExceptionModelPluginInit.so

we don't need to block this PR on macOS; if it fixes Ubuntu amd64 and ARM, we can add some comments to #800 about this and follow up later

@j-rivero
Copy link
Contributor Author

j-rivero commented Jan 19, 2021

Needs to be tested on ARM.

Let's try Build Status

apparently MODULE libraries have a .so suffix on macOS (while shared libraries end with .dylib, see #800 and this stackover answer), so I think we'll need to update the logic in Plugin.hh in order to load .so files as plugins on macOS

Interesting. I agree on following on #800.

@scpeters
Copy link
Member

@j-rivero I just merged with gazebo11, so this should be up to date now. Do you think we can try another ARM test build of this branch?

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters
Copy link
Member

arm test build:

@scpeters
Copy link
Member

arm test build:

I started another job but it didn't finish

Build Status https://build.osrfoundation.org/job/_test_gazebo-ci-pr_any-ubuntu_auto-arm64-gpu-nvidia/4/

@scpeters
Copy link
Member

scpeters commented May 5, 2021

it's looking better; the arm build succeeded, though there are more test failures than normal and the console output suggests a runtime problem

395: Unsupported setsockopt level=0 optname=32
395: Error setting socket option (IP_MULTICAST_IF).
395: Unsupported setsockopt level=0 optname=32
395: Error setting socket option (IP_MULTICAST_IF).
395: Did you set the environment variable IGN_IP with a correct IP address? 
395:   [172.17.0.2] seems an invalid local IP address.
395:   Using 127.0.0.1 as hostname.
395: terminate called after throwing an instance of 'std::out_of_range'
395:   what():  vector::_M_range_check: __n (which is 0) >= this->size() (which is 0)
395: qemu: uncaught target signal 6 (Aborted) - core dumped

Build Status https://build.osrfoundation.org/job/_test_gazebo-ci-pr_any-ubuntu_auto-arm64-gpu-nvidia/7/

the windows build is failing though

Scanning dependencies of target gtest_main
Error: dependent 'test\gtest.lib' does not exist.

Build Status https://build.osrfoundation.org/job/gazebo-ci-pr_any-windows7-amd64/3203/

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for all the iteration and fixing the changelog!

@scpeters scpeters merged commit e2436b3 into gazebo11 May 8, 2021
@scpeters scpeters deleted the revert_2753 branch May 8, 2021 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PluginTest failing since plugins became static libraries
2 participants