Fix build on Linux with conda-forge dependencies #2944
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the last two fixes that are required to build Gazebo with conda-forge provided dependencies on Linux without any further modification (verified in https://github.com/traversaro/gazebo-conda-forge-ci/pull/2/checks?check_run_id=2024424151, the test suite has some failures, but that's another story).
The fixes are:
cxx_std_11
compile feature is set for all the libraries in https://github.com/osrf/gazebo/blob/67c43463c87685b7c9d485a9f8d2e6ac760815b9/cmake/GazeboUtils.cmake#L106 and https://github.com/osrf/gazebo/blob/67c43463c87685b7c9d485a9f8d2e6ac760815b9/cmake/GazeboUtils.cmake#L120 . Furthermore, it can create problems when external libraries export other compile features (such as ignition-math6 that exportcxx_std_17
).RestApi.cc
use C++ stylecinttypes
instead of C styleinttypes.h
.