Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on Linux with conda-forge dependencies #2944

Merged
merged 2 commits into from
Mar 25, 2021

Conversation

traversaro
Copy link
Collaborator

These are the last two fixes that are required to build Gazebo with conda-forge provided dependencies on Linux without any further modification (verified in https://github.com/traversaro/gazebo-conda-forge-ci/pull/2/checks?check_run_id=2024424151, the test suite has some failures, but that's another story).

The fixes are:

Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the last two fixes that are required to build Gazebo with conda-forge

Amazing! Thanks Silvio.

I've relaunched the CI on Brew to check that things are fine with clang there. If CI is happy, I'm happy too.

@scpeters
Copy link
Member

These are the last two fixes that are required to build Gazebo with conda-forge

Amazing! Thanks Silvio.

I've relaunched the CI on Brew to check that things are fine with clang there. If CI is happy, I'm happy too.

brew CI looks ok

@scpeters scpeters merged commit fcffcd9 into gazebosim:gazebo11 Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants