This repository has been archived by the owner on Feb 3, 2025. It is now read-only.
Specify wide angle camera cube map texture format #2960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The WideAngleCamera has a texture for a cube map that uses the same pixel format as the camera image. If there are intermediate shaders applied to the camera, the choice of this image format may cause pixel values to be truncated. To provide flexibility to the user, the pixel format for the cube map texture can be specified with a custom SDFormat element in `//camera/lens/gazebo:env_texture_format` using the same values as `//camera/image/format`. Add friend WideAngleCamera statement to Camera.hh to allow access to private OgrePixelFormat method. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This matches the values used in ignition. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Test update_rate parameter value of 3.03 instead of 0.03 to reduce test time from over 30 seconds to about 1 second. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
* Added color setting to LensFlare and LensFlareSensorPlugin. Added methods to expose scale and color to derived plugins. * Removed unused animated lens flare effect. * Removed noise_rgba.png, which is no longer used. * Changed a value in the lens flare shader back to its original 1.0. This means there will be no compensation for the removal of the legacy animation effect and the lens flares will look less intense.
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
…a_cube_map_texture_format
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
Signed-off-by: Audrow Nash <audrow@hey.com>
scpeters
reviewed
Apr 7, 2021
scpeters
reviewed
Apr 8, 2021
Signed-off-by: Audrow Nash <audrow@hey.com>
scpeters
reviewed
Apr 8, 2021
Signed-off-by: Audrow Nash <audrow@hey.com>
scpeters
approved these changes
Apr 9, 2021
|
CI looks ok to me |
iche033
approved these changes
Apr 13, 2021
WilliamLewww
pushed a commit
to WilliamLewww/gazebo
that referenced
this pull request
Apr 13, 2021
The WideAngleCamera has a texture for a cube map that uses the same pixel format as the camera image. If there are intermediate shaders applied to the camera, the choice of this image format may cause pixel values to be truncated. To provide flexibility to the user, the pixel format for the cube map texture can be specified with a custom SDFormat element in `//camera/lens/ignition:env_texture_format` using the same values as `//camera/image/format`. Add friend WideAngleCamera statement to Camera.hh to allow access to private OgrePixelFormat method. Camera: recognize R_FLOAT16 and R_FLOAT32 to match ignition. * PhysicsEngine_TEST: speed up test Test update_rate parameter value of 3.03 instead of 0.03 to reduce test time from over 30 seconds to about 1 second. Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Add test for wide angle camera with texture plugin * Add check that grayscale image isn't black Signed-off-by: Audrow Nash <audrow@hey.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
scpeters
added a commit
to scpeters/gazebo
that referenced
this pull request
Apr 14, 2021
The WideAngleCamera has a texture for a cube map that uses the same pixel format as the camera image. If there are intermediate shaders applied to the camera, the choice of this image format may cause pixel values to be truncated. To provide flexibility to the user, the pixel format for the cube map texture can be specified with a custom SDFormat element in `//camera/lens/ignition:env_texture_format` using the same values as `//camera/image/format`. Add friend WideAngleCamera statement to Camera.hh to allow access to private OgrePixelFormat method. Camera: recognize R_FLOAT16 and R_FLOAT32 to match ignition. * PhysicsEngine_TEST: speed up test Test update_rate parameter value of 3.03 instead of 0.03 to reduce test time from over 30 seconds to about 1 second. Signed-off-by: Steve Peters <scpeters@openrobotics.org> * Add test for wide angle camera with texture plugin * Add check that grayscale image isn't black Signed-off-by: Audrow Nash <audrow@hey.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets the texture format based on the custom element
//camera/lens/gazebo:env_texture_format.Fixes #2928.