Cherry-pick LensFlare api changes to 11 #2974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add LensFlarePrivate setter methods and move LensFlareCompositorListener defintion to header * Modified LensFlareCompositorListener members to follow PIMPL * Reduce line length and fix whitespace Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: kbjeppes <kaden.b.jeppesen@nasa.gov> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
This is an adjustment to API added in gazebosim#2965, which is allowed because the API has not yet been released. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Martin Pecka <peckama2@fel.cvut.cz>
* Remove modifications to the shadow technique done in the DepthCamera, this is not necessary and breaks lighting for all other cameras that will render after it in the same frame * Add call to setShadowsEnabled for the normals viewport as well Co-authored-by: Steve Peters <scpeters@openrobotics.org>
scpeters
force-pushed
the
pick_lensflare_api
branch
from
8e4c464 to
f04fc15
Compare
iche033
approved these changes
Apr 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick the following pull requests forward to gazebo11. Use rebase and merge.