Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Find tbb version < 2021 with pkg-config #3037

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Jul 1, 2021

We don't support 2021 and newer, see #2867. A recent release of tbb in Homebrew/homebrew-core#80329 added a .pc file, which defeated the logic we added in gazebo-tooling/release-tools#466 to find our back-dated version of tbb@2020_u3 added in osrf/homebrew-simulation#1483 and which does not install a .pc file. To avoid finding the new version, add a <2021 version constraint to pkg_check_modules so it should not accept a .pc file from 2021 or later.

We don't support 2021 and newer, see gazebosim#2867.

Signed-off-by: Steven Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from j-rivero July 1, 2021 18:20
@j-rivero j-rivero merged commit 9cd47a0 into gazebosim:gazebo11 Jul 6, 2021
@scpeters scpeters deleted the find_old_tbb branch July 22, 2021 08:14
scpeters added a commit to scpeters/gazebo that referenced this pull request Aug 8, 2021
We currently don't support 2021 and newer, see gazebosim#2867.

Signed-off-by: Steven Peters <scpeters@openrobotics.org>
scpeters added a commit that referenced this pull request Aug 11, 2021
We currently don't support 2021 and newer, see #2867.

Signed-off-by: Steven Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants