Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move a couple of multilink worlds to to test directory #3059

Merged
merged 1 commit into from
Aug 12, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Aug 10, 2021

A follow-up PR to #3031.

The multilink_shape_nested.world and multilink_shape_included.world are used by ModelListWidget_TEST and references models in the test/models directory so we should just move them to test/worlds directory. They can't be launched in normal simulation mode since gazebo will complain that the models are not found.

Signed-off-by: Ian Chen ichen@osrfoundation.org

Signed-off-by: Ian Chen <ichen@osrfoundation.org>
@iche033 iche033 requested a review from j-rivero August 10, 2021 04:15
Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've restarted the homebrew build to be sure but changes looks good to me. Feel free to merge if CI is happy.

@iche033 iche033 merged commit dd4cfce into gazebo11 Aug 12, 2021
@iche033 iche033 deleted the mv_multilink_test_world branch August 12, 2021 01:32
iche033 added a commit that referenced this pull request Aug 12, 2021
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants