-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optionally disable "render back faces" for the shadow caster #3117
Optionally disable "render back faces" for the shadow caster #3117
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just some minor comments
this->dataPtr->shadowCasterRenderBackFaces = | ||
this->dataPtr->sdf->GetElement("scene")-> | ||
Get<bool>("ignition:shadow_caster_render_back_faces"); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks fine. I think if we plane to add more shadow params in the future, we can consider adding a <shadows> </shadows>
section to group these parameters
we could consider adding this new field to scene.proto in the ign-msgs |
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just made one very minor comment. Otherwise looks good.
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we included a test in #3048. would it be hard to do so here as well?
…terMaterialName Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
Signed-off-by: William Lew <WilliamMilesLew@gmail.com>
I added a test for the |
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
unfortunately the new test is failing on macOS I'll try to reproduce and debug the failure on my laptop |
Could this be the same thing that made the test fail for #3048? I remember resorting to excluding the test on MacOS. |
the test passes on my laptop; let's just merge it as is |
Added a new SDF parameter
ignition:shadow_caster_render_back_faces
to specify if back faces should be rendered by the shadow caster.Currently, the scene is hard-coded to always render back faces.
Based off pull request: #3048