Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in the check for whether the TBB target exists in gazebo-config.cmake.in #3207

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Fix typo in the check for whether the TBB target exists in gazebo-config.cmake.in #3207

merged 1 commit into from
Apr 7, 2022

Conversation

kartikmohta
Copy link
Contributor

No description provided.

@j-rivero
Copy link
Contributor

j-rivero commented Apr 7, 2022

Thanks for the PR Kartik! Could it be the case that different package systems are offering the tbb component with different names, sometimes in uppercase, sometimes in lowercase? Do you have a pointer at hand to the upstream code that generates the CMake component?

@traversaro
Copy link
Collaborator

Thanks @kartikmohta , indeed I think this was an error introduced in #3174 .

@scpeters
Copy link
Member

scpeters commented Apr 7, 2022

Thanks for the PR Kartik! Could it be the case that different package systems are offering the tbb component with different names, sometimes in uppercase, sometimes in lowercase? Do you have a pointer at hand to the upstream code that generates the CMake component?

it does look like a fix of a typo to me, since it now matches the target name on line 230

@scpeters
Copy link
Member

scpeters commented Apr 7, 2022

thanks so much for the fix!

@scpeters scpeters merged commit 72d47eb into gazebosim:gazebo11 Apr 7, 2022
@kartikmohta kartikmohta deleted the fix/gazebo-config-cmake-tbb branch April 8, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants