Support shininess value for each Visual in a Model #3235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a method to refactor access to the world shininess map, to ensure that map entries aren't added during access by using at() isntead of []. Also add a mutex to protect the shininess map and fix a doc-string. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This moves the parsing of shininess values from World::LoadModel to Link::UpdateVisualMsg and stores the values by scoped Visual name rather than by Model name. The per-model gz services are also replaced by a single /shininess service. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in #3232, only a single shininess value is currently supported for each model. This pull request expands the functionality of the ignition service interface so that the shininess of each Visual in a Model can be queried independently. This works by storing the shininess values by the scoped visual name. It also replaces the per-model ignition services with a single
/shininessservice.It is technically a change to the transport interface, but since this is such a new feature and improved by the current changes, I think it is an acceptable behavior change.
Fixes #3232.