Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SphericalCoordinates: support Lunar calculations #3250

Merged
merged 6 commits into from
Sep 3, 2022

Conversation

adityapande-1995
Copy link
Contributor

@adityapande-1995 adityapande-1995 commented Aug 9, 2022

This is PR aims to add gazebosim/gz-math#434 to gazebo classic, as a part of ongoing ticket to backport
support for lunar DEMs and supress projection errors.

This one makes changes in common::SphericalCoordinates analogous to the ones in gz-math.

Signed-off-by: Aditya aditya050995@gmail.com

Signed-off-by: Aditya <aditya050995@gmail.com>
@scpeters scpeters changed the title Modify distance calculation method in spherical coords class SphericalCoordinates: support Lunar calculations Aug 10, 2022
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
@adityapande-1995 adityapande-1995 marked this pull request as ready for review August 16, 2022 20:17
Signed-off-by: Aditya <aditya050995@gmail.com>
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one minor comment; looks good

gazebo/common/SphericalCoordinates.cc Outdated Show resolved Hide resolved
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
@scpeters scpeters merged commit e7ffa15 into aditya/lunar_dem_base Sep 3, 2022
@scpeters scpeters deleted the aditya/add_moon_spherical_coords branch September 3, 2022 00:03
scpeters added a commit that referenced this pull request Nov 4, 2022
* SphericalCoordinates: support Lunar calculations (#3250)
  Add support for MOON_SCS in spherical coords

Signed-off-by: Aditya <aditya050995@gmail.com>

* Use DistanceBetweenPoints when loading DEMs (#3252)

Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>

* Make Heightmap loader use spherical coordinates. (#3258)
  Make Physics.cc and Gazebo GUI use spherical coordinates
  when loading terrains.

Signed-off-by: Aditya <aditya050995@gmail.com>
Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants