-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SphericalCoordinates: support Lunar calculations #3250
Merged
scpeters
merged 6 commits into
aditya/lunar_dem_base
from
aditya/add_moon_spherical_coords
Sep 3, 2022
Merged
SphericalCoordinates: support Lunar calculations #3250
scpeters
merged 6 commits into
aditya/lunar_dem_base
from
aditya/add_moon_spherical_coords
Sep 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aditya <aditya050995@gmail.com>
scpeters
changed the title
Modify distance calculation method in spherical coords class
SphericalCoordinates: support Lunar calculations
Aug 10, 2022
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
Signed-off-by: Aditya <aditya050995@gmail.com>
scpeters
reviewed
Sep 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one minor comment; looks good
Signed-off-by: Aditya <aditya050995@gmail.com>
scpeters
reviewed
Sep 2, 2022
Signed-off-by: Aditya <aditya050995@gmail.com>
scpeters
approved these changes
Sep 3, 2022
Merged
scpeters
added a commit
that referenced
this pull request
Nov 4, 2022
* SphericalCoordinates: support Lunar calculations (#3250) Add support for MOON_SCS in spherical coords Signed-off-by: Aditya <aditya050995@gmail.com> * Use DistanceBetweenPoints when loading DEMs (#3252) Signed-off-by: Aditya <aditya050995@gmail.com> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org> * Make Heightmap loader use spherical coordinates. (#3258) Make Physics.cc and Gazebo GUI use spherical coordinates when loading terrains. Signed-off-by: Aditya <aditya050995@gmail.com> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR aims to add gazebosim/gz-math#434 to gazebo classic, as a part of ongoing ticket to backport
support for lunar DEMs and supress projection errors.
This one makes changes in
common::SphericalCoordinates
analogous to the ones in gz-math.Signed-off-by: Aditya aditya050995@gmail.com