Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][vcpkg][Windows] Build gazebo for windows with cmake vcpkg #3312

Closed

Conversation

talregev
Copy link
Contributor

@talregev talregev commented Apr 4, 2023

Build gazebo for windows with cmake vcpkg.
To find all dependencies need to change cmake that it will compile both with native and vcpkg build.
I will do it in next PR, and I will need community help.

All dependencies are cache, and It much faster configure when it take it from the cache folder.

@traversaro
@chapulina

@talregev talregev force-pushed the TalR/compile_gazebo_windows branch from 28a68d9 to f803493 Compare April 5, 2023 00:23
@talregev talregev changed the title [CI][vcpkg][Windows] Configure gazebo for windows with cmake vcpkg [CI][vcpkg][Windows] Build gazebo for windows with cmake vcpkg Apr 5, 2023
@talregev talregev force-pushed the TalR/compile_gazebo_windows branch 6 times, most recently from 608fde8 to 882e22d Compare April 6, 2023 06:42
@talregev talregev force-pushed the TalR/compile_gazebo_windows branch 2 times, most recently from 2fb484f to ac612f6 Compare April 23, 2023 08:38
@talregev talregev force-pushed the TalR/compile_gazebo_windows branch 2 times, most recently from 502f064 to 8418c7b Compare April 28, 2023 05:13
@talregev
Copy link
Contributor Author

@traversaro from our conversion here:
microsoft/vcpkg#31280
Can I do anything to help getting this PR?

@traversaro
Copy link
Collaborator

@talregev Thanks for the contribution. The deps/vcpkg/manifests/windows/vcpkg.json is only useful for CI (in that case, we could also thinking of having this CI in a different repo), or it is useful to have it in the main repo for some reason?

@talregev
Copy link
Contributor Author

talregev commented May 13, 2023

@talregev Thanks for the contribution. The deps/vcpkg/manifests/windows/vcpkg.json is only useful for CI (in that case, we could also thinking of having this CI in a different repo), or it is useful to have it in the main repo for some reason?

It useful for any case that other want to build gazebo in windows.
You can build gazebo without the ci (with the commands from the ci).
This PR give you a way how to compile gazebo on your windows pc without install anything. (except git)

@talregev
Copy link
Contributor Author

@traversaro you cannot build gazebo with vcpkg alone (with it own gazebo vcpkg.json file). It break. I made a PR for that.
You can read and have a comments there if you want:
microsoft/vcpkg#30424

Currently to build gazebo on windows without anaconda and with vcpkg, it with this PR.
So this file: deps/vcpkg/manifests/windows/vcpkg.json is part from the build.

@traversaro
Copy link
Collaborator

And the resulting Gazebo is then working or not? I just noticed #3320 , and from there it seems that the resulting gazebo is not starting.

@talregev
Copy link
Contributor Author

And the resulting Gazebo is then working or not? I just noticed #3320 , and from there it seems that the resulting gazebo is not starting.

The same here. But I think it not concerning the compilation. I think I am doing something wrong.
I know I compile gazebo correctly and with help of the community I will able to run it.

@traversaro
Copy link
Collaborator

The same here. But I think it not concerning the compilation. I think I am doing something wrong.
I know I compile gazebo correctly and with help of the community I will able to run it.

Thanks! So perhaps it could make sense to have something running before merging this PR? In the meanwhile, you could host the vcpkg.json metadata in a separate repository, so people that want to test can easily do that (by specifying the location of the vcpkg.json via VCPKG_MANIFEST_DIR).

@talregev
Copy link
Contributor Author

talregev commented May 15, 2023

Thanks! So perhaps it could make sense to have something running before merging this PR?

I know the compilation is correct. Do you think we need to do something else in compilation?
If compilation is correct, and can verify with you, we can merge this PR.

Do you have windows machine to test it out too?

In the meanwhile, you could host the vcpkg.json metadata in a separate repository

Why you want to host the vcpkg.json in a separate repository? It part of the build. It tell which packages to install.
It the same you have a CMakeLists.txt and inside all the find packages for all your 3rdparties.

If you want other will test it easily too, then leave the vcpkg.json on this repo. There is no meaning for this build, or this PR when we put this in other place.

@talregev talregev force-pushed the TalR/compile_gazebo_windows branch from 8418c7b to d9f1433 Compare June 15, 2023 05:07
@talregev talregev force-pushed the TalR/compile_gazebo_windows branch from d9f1433 to f64948b Compare June 16, 2023 06:38
@talregev
Copy link
Contributor Author

@traversaro This is outdated version. I switch to other PR I did:
x64 + x86
#3320

@talregev talregev closed this Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants