Remove GZ_SINGLETON_DECLARE definition workaround (fix for armhf) #3283
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jose Luis Rivero jrivero@osrfoundation.org
🦟 Bug fix
Fixes #3208.
Summary
The trick of defining the template function specialized was introduced in a commit part of the Windows works as part of the Windows works, seems to me like a workaround to make the compilation to work somehow. On my Jammy testing system, both clang and gcc compiled it fine with this PR and packages were made using gcc for arm64, armhf and ppc64.
Did not test it on Windows, let's see if the CI is happy or it was indeed needed.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.