Fix build with graphviz 10.0 #3373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace TRUE with 1, since the TRUE macro has been removed. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
traversaro
approved these changes
Feb 21, 2024
8 tasks
2001herne
added a commit
to 2001herne/gazebo-arch
that referenced
this pull request
Mar 4, 2024
…allow building with graphviz 10.
2001herne
added a commit
to 2001herne/gazebo-arch
that referenced
this pull request
Mar 5, 2024
…allow building with graphviz 10. Fixes acxz#94
2001herne
added a commit
to 2001herne/gazebo-arch
that referenced
this pull request
Mar 5, 2024
…allow building with graphviz 10. Fixes acxz#94
This was referenced Jun 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Fixes #3372.
Summary
The
TRUEmacro has been removed in graphviz 10.0, which was recently released in homebrew-core. The fix is to replaceTRUEwith1.To test: verify that the homebrew build compiles successfully.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.