-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build examples using native CMake #301
Merged
Merged
Changes from 9 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5873c25
Add a way to externally override include dirs
mjcarroll ded67ec
Macro to generate examples in Gazebo projects
mjcarroll cd0200c
Merge branch 'gz-cmake3' into mjcarroll/examples_from_cmake
mjcarroll 6a9dabd
Pass through build and generator types
mjcarroll ae8dd03
Merge branch 'mjcarroll/examples_from_cmake' of ssh://github.com/gaze…
mjcarroll 0f2dbb6
Update cmake/GzUtils.cmake
mjcarroll bc7c31a
Merge branch 'gz-cmake3' into mjcarroll/examples_from_cmake
mjcarroll d4211d0
Address reviewer feedback
mjcarroll 96340f5
Merge branch 'gz-cmake3' into mjcarroll/examples_from_cmake
mjcarroll da51b36
Merge branch 'gz-cmake3' into mjcarroll/examples_from_cmake
mjcarroll c312464
Forward more necessary flags
mjcarroll 99cad79
Pick up components from build_configure
mjcarroll 67ab359
Merge branch 'gz-cmake3' into mjcarroll/examples_from_cmake
ahcorde 54af815
Merge branch 'gz-cmake3' into mjcarroll/examples_from_cmake
mjcarroll 7e558c7
Reduce complexity of adding cmake-native tests
mjcarroll b515afa
Merge branch 'gz-cmake3' into mjcarroll/examples_from_cmake
mjcarroll 7ae5391
Use quotes
mjcarroll 90fa541
Merge branch 'gz-cmake3' into mjcarroll/examples_from_cmake
mjcarroll File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me see if I understand this right: in
DEPENDENCIES
you can specify gz- libraries that are not being used by the build system of the project but are required to make the examples to build/run? Is this correct? If so, bellow there is a comment:How does this work if a dependency is not in the current buildsystem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a slight rework to this I can push shortly that drops this gymnastics a bit.
Note that this is only necessary for gazebo packages, as they may be built in the same workspace, so this special forwarding happens.
Currently, examples aren't allowed to depend on Gazebo packages things that the containing package doesn't. E.g. gz-gui examples cannot have a dependency on gz-gazebo, as this will introduce circular dependencies.
If an example depends on a non-Gazebo package, then typical
find_package
infrastructure should work.