ign -> gz Migrate Ignition Headers : gz-cmake #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
methylDragon
requested review from
mxgrey,
j-rivero and
scpeters
as code owners
github-actions
bot
added
🏯 fortress
methylDragon
force-pushed
the
citadel_header_redirects
branch
9 times, most recently
from
8d87909 to
28e8448
Compare
scpeters
reviewed
Aug 19, 2022
CMakeLists.txt
Outdated
| ign_configure_project(VERSION_SUFFIX) | ||
| ign_configure_project( | ||
| REPLACE_IGNITION_INCLUDE_PATH gz/cmake | ||
| VERSION_SUFFIX pre1 |
There was a problem hiding this comment.
are we planning to make a prerelease?
There was a problem hiding this comment.
Oh, I thought the missing VERSION_SUFFIX was a bug :X
Let me remove
scpeters
reviewed
Aug 19, 2022
| */ | ||
|
|
||
| #ifndef IGNITION_UTILITIES_EXTRATESTMACROS_HH | ||
| #define IGNITION_UTILITIES_EXTRATESTMACROS_HH |
There was a problem hiding this comment.
use GZ_* for these header guards?
scpeters
reviewed
Aug 19, 2022
| #ifndef IGNITION_UTILITIES_DETAIL_SUPPRESSWARNING_HH_ | ||
| #define IGNITION_UTILITIES_DETAIL_SUPPRESSWARNING_HH_ | ||
| #ifndef GZ_UTILITIES_DETAIL_SUPPRESSWARNING_HH_ | ||
| #define GZ_UTILITIES_DETAIL_SUPPRESSWARNING_HH_ | ||
|
|
||
| #include <ignition/utilities/SuppressWarning.hh> |
methylDragon
force-pushed
the
citadel_header_redirects
branch
from
28e8448 to
532f347
Compare
methylDragon
changed the title
This was referenced Aug 26, 2022
|
@methylDragon do you mind merging this? I think you have a specific procedure involving rebase-and-merge. I'll take care of the release afterwards |
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: methylDragon <methylDragon@gmail.com>
methylDragon
force-pushed
the
citadel_header_redirects
branch
from
532f347 to
bf73342
Compare
methylDragon
added a commit
that referenced
this pull request
Aug 29, 2022
Signed-off-by: methylDragon <methylDragon@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: gazebo-tooling/release-tools#784