Skip to content

Commit

Permalink
Fix hierarchical submesh processing in the ColladaLoader. (#78)
Browse files Browse the repository at this point in the history
Fix hierarchical submesh processing in the ColladaLoader. #78

Signed-off-by: Nate Koenig <nate@openrobotics.org>
  • Loading branch information
nkoenig authored and mjcarroll committed Oct 14, 2020
1 parent 771aea6 commit f4f07ce
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
3 changes: 3 additions & 0 deletions Changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@

## Ignition Common 3.X.X

1. Fix hierarchical submesh processing in the ColladaLoader.
* [Pull Request 78](https://github.com/ignitionrobotics/ign-common/pull/78)

## Ignition Common 3.6.0 (2020-06-09)

1. Refactor Image::MaxColor to reduce computation time
Expand Down
10 changes: 5 additions & 5 deletions graphics/src/ColladaLoader.cc
Original file line number Diff line number Diff line change
Expand Up @@ -466,18 +466,18 @@ void ColladaLoaderPrivate::LoadNode(tinyxml2::XMLElement *_elem, Mesh *_mesh,
ignition::math::Matrix4d transform = this->LoadNodeTransform(_elem);
transform = _transform * transform;

if (_elem->Attribute("name"))
{
this->currentNodeName = _elem->Attribute("name");
}

nodeXml = _elem->FirstChildElement("node");
while (nodeXml)
{
this->LoadNode(nodeXml, _mesh, transform);
nodeXml = nodeXml->NextSiblingElement("node");
}

if (_elem->Attribute("name"))
{
this->currentNodeName = _elem->Attribute("name");
}

if (_elem->FirstChildElement("instance_node"))
{
std::string nodeURLStr =
Expand Down

0 comments on commit f4f07ce

Please sign in to comment.