Fix loading dae file with hierarchical node that does not have a name #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
github-actions
bot
added
🏰 citadel
Codecov Report
@@ Coverage Diff @@
## ign-common3 #101 +/- ##
===============================================
+ Coverage 73.94% 73.96% +0.02%
===============================================
Files 69 69
Lines 9406 9418 +12
===============================================
+ Hits 6955 6966 +11
- Misses 2451 2452 +1
Continue to review full report at Codecov.
|
luca-della-vedova
approved these changes
Sep 29, 2020
|
Looks like the Ubuntu build is erroring due to low disk space: https://build.osrfoundation.org/job/ignition_common-ci-pr_any-ubuntu_auto-amd64/395/console |
|
@iche033 Do you think you can add a |
|
yep added test in d958def |
mjcarroll
reviewed
Oct 12, 2020
mjcarroll
approved these changes
Oct 12, 2020
Signed-off-by: Ian Chen <ichen@osrfoundation.org>
JShep1
pushed a commit
that referenced
this pull request
Oct 14, 2020
…#101) Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
mjcarroll
pushed a commit
that referenced
this pull request
Oct 14, 2020
…#101) Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
mjcarroll
pushed a commit
that referenced
this pull request
Oct 19, 2020
…#101) Signed-off-by: Ian Chen <ichen@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org> Signed-off-by: Michael Carroll <michael@openrobotics.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pull request #78 fixed loading hierarchical submeshes in ColladaLoader but we ran into an edge case that if a node in the dae file does not have a name, it would be given the name of the previous node. For example,the Polaris Ranger EV model model has the node structure below and the result is that the nested node inside
node_Bwould be incorrectly given the namenode_A:The fix adds the logic to check that if a node does not have a name, it'll then be appended and become part of the parent mesh. It restores the original behavior before pull request #78 was merged while preserving the hierarchical submesh fix.
Signed-off-by: Ian Chen ichen@osrfoundation.org