Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup: Drop unused forward declaration #113

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

mjcarroll
Copy link
Contributor

Followup of #104

Signed-off-by: Michael Carroll michael@openrobotics.org

@mjcarroll mjcarroll requested a review from chapulina October 29, 2020 20:19
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Oct 29, 2020
Signed-off-by: Michael Carroll <michael@openrobotics.org>
@mjcarroll mjcarroll force-pushed the drop_forward_delcaration branch from 51a4cee to 8f507f7 Compare October 29, 2020 21:42
@codecov
Copy link

codecov bot commented Oct 29, 2020

Codecov Report

Merging #113 into ign-common3 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##           ign-common3     #113   +/-   ##
============================================
  Coverage        73.99%   73.99%           
============================================
  Files               69       69           
  Lines             9433     9433           
============================================
  Hits              6980     6980           
  Misses            2453     2453           
Impacted Files Coverage Δ
graphics/src/Animation.cc 91.83% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06e3421...8f507f7. Read the comment docs.

@mjcarroll mjcarroll merged commit 0d44a6e into ign-common3 Oct 30, 2020
@mjcarroll mjcarroll deleted the drop_forward_delcaration branch October 30, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome 🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants